More ptp2 event logging improvements #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly count the number of events, such that amount allocated fits with amount required. Warn if a mismatch happens.
This shall help with comparing the event log with USB packet traces. Also
tune the layout to accommodate the new info.
example log:
event 635:c18a: prop d175 options changed, type 3, count 1 (EOS_NetworkCommunicationMode)
prop d175 option[ 0] == 0x00
event 636:c18a: prop d244 options changed, type 3, count 3 ((null)) (unknown)
event 637:c1a4: CTGInfoCheckComplete 0x00020001
event 638:c19d: unhandled EOS event PowerZoomInfoChanged (size 12)
0x000: - - - -
event 639:c1a5: OLCInfoChanged (size 100, version 0x14, mask 0x1fff)
0x000: 60 - - - ff 1f - - 01 - 01 01 - a0 - 10
0x010: - 68 - 01 03 - 50 - 20 - 38 - 01 01 - -
0x020: 78 28 - 04 01 06 41 - - - - - - 01 01 -
0x030: - - - - - - - 01 - - - - - - - -
0x040: - - - - - - - - - - - - - - - -
0x050: - - - - - - - - - - - -
event 639:0001: (olcmask) 2 bytes: 01 00
event 640:0002: (olcmask) 9 bytes: 01 01 00 a0 00 10 00 68 00
event 641:0004: (olcmask) 9 bytes: 01 03 00 50 00 20 00 38 00
event 642:0008: (olcmask) 7 bytes: 01 01 00 00 78 28 00
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
(added commit 8b8c81c after afl showed new crashes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.